Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Specifying strategy parameter on native command does not work anymore #297

Closed
weilbith opened this issue Oct 4, 2023 · 2 comments
Closed

[BUG] Specifying strategy parameter on native command does not work anymore #297

weilbith opened this issue Oct 4, 2023 · 2 comments
Assignees
@rcarriga

Comments

@weilbith
Copy link
Contributor

weilbith commented Oct 4, 2023

NeoVim Version
v0.10.0-dev-1913041

Describe the bug
When specifying the strategy as parameter to the Neotest command, it gets swallowed.

To Reproduce

Steps to reproduce the behavior:

  1. Run :Neotest run strategy=dap
  2. It executes without applying the strategy

Expected behavior
Strategy parameter works

Additional context
I investigated and the issue is in in the eval_luastring, which is used for the make_params. It refers to the loadstring function which is shown as depracted for me. Anyway, if it tries to parse the command argument strategy=dap, it tries to "load" the string "dap", which is always nil.
What is this supposed to do? I would like to open a PR fixing it, but I'm confused.
rcarriga pushed a commit that referenced this issue Oct 20, 2023
fix(command): evaluate unquoated string args
9018914 
See #297
@rcarriga
Copy link
Collaborator

Should be fixed in latest master 😄

@weilbith
Copy link
Contributor Author

Nice! Thank you very much! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcarriga rcarriga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weilbith @rcarriga