Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

Implement glennguy's MediaStyle notifications #63

Merged
merged 4 commits into from
Jan 11, 2020

Conversation

mlim15
Copy link
Contributor

@mlim15 mlim15 commented Jan 11, 2020

From daneren2005/Subsonic#914. I removed the thumbs up/down stuff and rewind/fast forward because there is no equivalent functionality in-app for Audinaut. Tried to use file comparison to keep your convention and whitespace changes.

I tested this a bit but I obviously don't really know what I'm doing so please test further before merging.

@mlim15
Copy link
Contributor Author

mlim15 commented Jan 11, 2020

Looks weird on Android 10 and I don't know why

Android 10 apparently implements a seek bar in Mediastyle notifications by default. This does not appear in older versions of Android. I will see if I can handle this and try again. This issue is related to the colorization, giving mediastyle the session token in order to colorize is also what causes the seek bar to appear

@mlim15 mlim15 closed this Jan 11, 2020
@nvllsvm nvllsvm reopened this Jan 11, 2020
@nvllsvm nvllsvm merged commit bf9e9ad into nvllsvm:master Jan 11, 2020
@nvllsvm
Copy link
Owner

nvllsvm commented Jan 11, 2020

This is a step in the right direction so I merged it. Android 10 can be fixed in master.

@mlim15
Copy link
Contributor Author

mlim15 commented Jan 12, 2020

I didn't realize that the pull request would get updated when I made commits to its branch. I think
153ccdd solved the Android 10 seek bar problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants