Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Tests to run on CI (GitHub Actions) #2576

Closed
ShaileshKumar007 opened this issue Sep 2, 2021 · 1 comment · May be fixed by #2577
Closed

[Feature]: Tests to run on CI (GitHub Actions) #2576

ShaileshKumar007 opened this issue Sep 2, 2021 · 1 comment · May be fixed by #2577

Comments

@ShaileshKumar007
Copy link

Problem:

Tests not running on push or pull request.

Solution :

Added to GitHub Actions
ShaileshKumar007 added a commit to ShaileshKumar007/nvm that referenced this issue Sep 2, 2021
@ShaileshKumar007
feat: tests to run on GitHub Actions (nvm-sh#2576)
5a90b32
@ShaileshKumar007 ShaileshKumar007 mentioned this issue Sep 2, 2021
Draft
@ljharb
Copy link
Member

ljharb commented Sep 2, 2021

Tests run perfectly fine on push and on pull requests. Some of the tests already do use github actions; some still do not.

Closing as a duplicate of #2465.

@ljharb ljharb closed this as completed Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: tests to run on GitHub Actions (#2576) ShaileshKumar007/nvm
2 participants
@ljharb @ShaileshKumar007