Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrity protection for NW.js downloads #19

Closed
timmclean opened this issue Apr 5, 2015 · 1 comment
Closed

Integrity protection for NW.js downloads #19

timmclean opened this issue Apr 5, 2015 · 1 comment

Comments

@timmclean
Copy link

Currently, this installer downloads the NW.js binaries over insecure HTTP, leaving them open to malicious tampering (your computer could get pwned). Ideally, the binaries would have PGP signatures (pending nwjs/nw.js#3071) that could be verified, or would be available over HTTPS (pending nwjs/nw.js#3062).

I'd like to suggest an alternative that would be fairly simple to implement in the meantime. The autobump script could calculate the SHA-2 hash for each NW.js archive and save these hashes to package.json. When the install script runs, it could verify the downloaded file against the appropriate hash. It wouldn't be quite NSA-proof, but it would be a lot better than nothing.

If you're OK with this, I think I could put together a pull request with these changes sometime this week.

Cheers,
Tim

@shama
Copy link
Contributor

shama commented Apr 7, 2015

I'd be happy to support it when nw.js itself supports HTTPS downloads. I think implementing our own interim solution might just be adding complexity for false security.

Also please follow this issue regarding signed packages via npm: node-forward/discussions#29

I have subscribed to nwjs/nw.js#3062 and will follow up when that issue has been resolved.

Closing as a duplicate of: #2

@shama shama closed this as completed Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants