Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

func name DropCacheEntry is misleading #57

Open
nyaxt opened this issue Jan 5, 2016 · 0 comments
Open

func name DropCacheEntry is misleading #57

nyaxt opened this issue Jan 5, 2016 · 0 comments
Labels
enhancement P2

Comments

@nyaxt
Copy link
Owner

nyaxt commented Jan 5, 2016

CachedBlobEntriesManager.DropCacheEntry actually does the following:

  • writeBack any changes made to the blob
  • delete blob from cache to free up disk space

The name sounds like the cache entry is abandoned. There must be a better name for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nyaxt