Skip to content

Commit

Permalink
Add skypeForConsumer as conferencing provider. (#255)
Browse files Browse the repository at this point in the history
- Free Outlook accounts supports creating skype as conferencing while
creating events.
- Currently this is not listed as supported conferencing provider in
JAVA sdk.
- When user fetches event and an event has skype as conferencing, the
request fails due to unsupported conferencing.
- Add `skypeForConsumer` as supported conferencing provider.
- Reproduced the error locally and tested the fix locally.


# License
<!-- Your PR comment must contain the following line for us to merge the
PR. -->
I confirm that this contribution is made under the terms of the MIT
license and that I have the authority necessary to make this
contribution on behalf of its copyright owner.

---------

Co-authored-by: Subash Pradhan <[email protected]>
  • Loading branch information
SubashPradhan and Subash Pradhan authored Nov 29, 2024
1 parent 2dd721f commit 3e97fab
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Nylas Java SDK Changelog

### Unreleased
* Add support for `skypeForConsumer` as conferencing provider

### [2.5.1] - Released 2024-11-12
* Fixed response type for returning list of scheduled messages

Expand Down
3 changes: 3 additions & 0 deletions src/main/kotlin/com/nylas/models/ConferencingProvider.kt
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,7 @@ enum class ConferencingProvider {

@Json(name = "GoToMeeting")
GOTOMEETING,

@Json(name = "skypeForConsumer")
SKYPE_FOR_CONSUMER,
}

0 comments on commit 3e97fab

Please sign in to comment.