Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NylasClient open instead of final so we can mock it! #257

Open
lapostolovski opened this issue Dec 2, 2024 · 0 comments · May be fixed by #258
Open

Make NylasClient open instead of final so we can mock it! #257

lapostolovski opened this issue Dec 2, 2024 · 0 comments · May be fixed by #258
Labels
enhancement New feature or request

Comments

@lapostolovski
Copy link

We are integrating with Nylas and cannot cover our code with tests because NylasClient is declared final. Kotlin is making classes final by default.

Please remove the final declaration from NylasClient class and all related classes so we can mock it.

Another option for us is to make a proxy wrapper around NylasClient but it is much more typing and support, and we want to use the library to have less typing and code to support.
@lapostolovski lapostolovski added the enhancement New feature or request label Dec 2, 2024
devin-ai-integration bot added a commit that referenced this issue Dec 11, 2024
@devin-ai-integration @AaronDDM
feat: make NylasClient and its methods open for mocking
28706db 
This change makes the NylasClient class and its methods open to enable mocking in tests.
- Added open modifier to NylasClient class
- Made all resource accessor methods (messages, calendars, etc.) open
- Made HTTP execution methods open for comprehensive mocking support

Fixes #257

Co-Authored-By: Aaron de Mello <[email protected]>
@devin-ai-integration devin-ai-integration bot linked a pull request Dec 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make NylasClient and its methods open for mocking nylas/nylas-java
1 participant
@lapostolovski