Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata field to SendMessageRequest model #394

Open
JohnBurnsVC opened this issue Nov 21, 2024 · 0 comments · May be fixed by #398
Open

Add metadata field to SendMessageRequest model #394

JohnBurnsVC opened this issue Nov 21, 2024 · 0 comments · May be fixed by #398

Comments

@JohnBurnsVC
Copy link

Is your feature request related to a problem? Please describe.
Nylas API allows for setting a metadata field on Calendar, Event, Message, and Draft objects, but this repo doesn't currently account for this (documentation). It would be nice to be able to add metadata when sending Messages specifically (can see the API allows it on requests here).

Describe the solution you'd like
It seems reasonable to add a metadata field onto the SendMessageRequest model (and potentially the other "Send" models that metadata applies to).

Describe alternatives you've considered
Don't think there are any workarounds here.

Additional context
Would also be nice if Nylas API could include the metadata field on message.created webhooks -- it looks like they currently include all other Message fields except the metadata which is pretty inconvenient since it forces consumers to have to make an additional http call to the GET message endpoint to see the metadata.

devin-ai-integration bot added a commit that referenced this issue Dec 11, 2024
- Added metadata field to CreateDraftRequest which is inherited by SendMessageRequest
- Added test cases for metadata in draft creation and message sending
- Updated docstring to include metadata field description

Fixes #394

Co-Authored-By: Aaron de Mello <[email protected]>
@devin-ai-integration devin-ai-integration bot linked a pull request Dec 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant