Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock d3 version to last supported version for app #96

Merged
merged 1 commit into from
Nov 8, 2017

Conversation

rnkaufman
Copy link
Contributor

Fixes the syntax error upon server startup mentioned in: #95

@rnkaufman
Copy link
Contributor Author

@veltman Hi! I made this PR because it seems that d3 wasn't getting locked down in packages.json the way it was written before, so 4.10.1 was getting installed and messing up the way the settings/themes.json file gets loaded in. I would appreciate your eyes on this!

@veltman
Copy link
Contributor

veltman commented Oct 23, 2017

Thanks! Also should close #93.

Details on the issue: d3/d3-request#24

@noslouch can you merge this?

@noslouch noslouch merged commit c1b14f1 into nypublicradio:master Nov 8, 2017
AndresVoice123 pushed a commit to AndresVoice123/audiogram that referenced this pull request Sep 15, 2020
Lock d3 version to last supported version for app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants