-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arduino language support request #1171
Comments
Thanks for the request! Would you be willing to create your own ASCII art? Also, FYI π |
There's the ASCII art, it's supposed to be this color: #189ba1. |
(Posting the ASCII art in the comments for easier access)
Love the ASCII art! But we set a limit for width and height, and just looking at this it's a little big. Would you want to make a pull request? No Rust experience needed! |
I'm sorry but I'm not that expirienced in using GitHub, I don't know how to make a pull request on a public repo |
Got it, no pressure. I'm going to mark this as "help wanted" to open this issue up for anyone else to contribute. But making a PR is easy (IMO).
You might want to check this out: https://github.com/skills/introduction-to-github But no pressure if you don't want to π |
Off-topic: @o2sh The emojis in labels are pretty, but it looks like we're not discoverable by sites like https://goodfirstissues.com. Just an FYI |
And by making changes you mean adding the ASCII art txt file? |
We have contributing guidelines in Basically, And when we merge your PR you can brag about being a contributor for onefetch π |
Ok, but how do I create PR on this repo, when I did the edits in my forked one? |
When creating a PR you can change the base repository, which could also be thought of as the target repository. I went ahead and made the PR for you, though π #1173 |
Oh I overlooked that thank you. So other than the review it's done? |
Yeah pretty much. You might want to subscribe to #1173 so you're notified when we add comments. |
Thanks for pointing that out @spenserblack, I created an issue on their repo iedr/goodfirstissues#57 |
Thanks for finding the repo! Looks like this is the relevant query: https://github.com/iedr/goodfirstissues/blob/36dde6c91654287fc84eaf657dfcce0eccf72284/backend/main-to-file.go#L68-L81 |
Closed in #1176 |
Language Name π
Arduino (.ino files)
Logo π·
No response
Upstream support β
The text was updated successfully, but these errors were encountered: