feat: add Twig language support with ASCII art and color scheme #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spenserblack
approved these changes
Jan 20, 2024
languages.yaml
Outdated
| @{0}...........:77:...:~!!!~:.............@{0} | ||
| @{0}...........:^^:.......................@{0} | ||
| @{0}......................................@{0} | ||
| ######################################## |
There was a problem hiding this comment.
@o2sh what do you think, should these characters be explicitly styled as "white"?
There was a problem hiding this comment.
I meant that, instead of just {0} with green, it might be better to have two colors, {0} and {1} for white and green.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
spenserblack
approved these changes
Mar 31, 2024
There was a problem hiding this comment.
I think this change I pushed represents the intended style. @arferreira let me know if this is true.
|
BTW 😉 spenserblack/gengo#34 (context: #1305) |
|
The ASCII logo needs some rework. I'll revert it for now and will try to come up with a better design. Sorry for not stepping in earlier. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for Twig
#490
Tell me what you think about the proposal
Original logo: