Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding test coverage to src/info/info_field.rs #810

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Adding test coverage to src/info/info_field.rs #810

merged 2 commits into from
Oct 7, 2022

Conversation

alessandroasm
Copy link
Contributor

As requested as an item on task #700

@alessandroasm
Adding test coverage to src/info/info_field.rs
b5d3151 
As requested as an item on task #700
spenserblack
spenserblack reviewed Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This style is influence by my Go usage, but since this is a mock struct that exists to test a trait's provided method, I wonder if it makes sense to simplify the struct's definition like this.

src/info/info_field.rs Outdated Show resolved Hide resolved
src/info/info_field.rs Outdated Show resolved Hide resolved
src/info/info_field.rs Outdated Show resolved Hide resolved
src/info/info_field.rs Outdated Show resolved Hide resolved
src/info/info_field.rs Outdated Show resolved Hide resolved
@alessandroasm
Copy link
Contributor Author

@spenserblack Awesome suggestion! I just pushed a commit with the changes. Thank you 👍

spenserblack
spenserblack approved these changes Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping us improve our testing!

@o2sh o2sh merged commit 3cb479a into o2sh:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spenserblack spenserblack spenserblack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessandroasm @spenserblack @o2sh