From bba714e111c5fe99d5edbce23afd838ff29c9c3c Mon Sep 17 00:00:00 2001
From: zen0bit <zenobit@disroot.org>
Date: Thu, 4 Apr 2024 18:22:13 +0200
Subject: [PATCH 1/2] lint

---
 quickget | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/quickget b/quickget
index 4ea03d1fb8..f18156db69 100755
--- a/quickget
+++ b/quickget
@@ -818,18 +818,18 @@ function releases_ubuntu() {
 
     case "${OS}" in
         edubuntu|ubuntu-unity|ubuntucinnamon)
-        echo ${INTERIM_SUPPORT[@]} daily-live
+        echo "${INTERIM_SUPPORT[@]}" daily-live
         ;;
         kubuntu|lubuntu|ubuntukylin|ubuntu-mate|ubuntustudio|xubuntu)
         ## after 14.04
-        echo ${LTS_SUPPORT[@]:1} ${INTERIM_SUPPORT[@]} daily-live jammy-daily ${EOL_VERSIONS[@]/#/eol-}
+        echo "${LTS_SUPPORT[@]:1}" "${INTERIM_SUPPORT[@]}" daily-live jammy-daily "${EOL_VERSIONS[@]/#/eol-}"
         ;;
         ubuntu-budgie)
         #after 16.04
-        echo ${LTS_SUPPORT[@]:2} ${INTERIM_SUPPORT[@]} daily-live jammy-daily ${EOL_VERSIONS[@]/#/eol-}
+        echo "${LTS_SUPPORT[@]:2}" "${INTERIM_SUPPORT[@]}" daily-live jammy-daily "${EOL_VERSIONS[@]/#/eol-}"
         ;;
         ubuntu)
-        echo ${LTS_SUPPORT[@]} ${INTERIM_SUPPORT[@]} daily-live ${EOL_VERSIONS[@]/#/eol-}
+        echo "${LTS_SUPPORT[@]}" "${INTERIM_SUPPORT[@]}" daily-live "${EOL_VERSIONS[@]/#/eol-}"
         ;;
     esac
 }
@@ -852,7 +852,7 @@ function releases_ubuntu-server() {
         fi
     done
 
-    echo ${LTS_SUPPORT[@]} ${INTERIM_SUPPORT[@]} daily-live
+    echo "${LTS_SUPPORT[@]}" "${INTERIM_SUPPORT[@]}" daily-live
 }
 
 function releases_vanillaos() {
@@ -2785,6 +2785,7 @@ if [ -n "${2}" ]; then
 
         # Handle odd missing fedora cominations
         if [[ $OS == fedora ]] ; then
+            #shellcheck disable=SC2071
             if [[ ${RELEASE} = "33" && ${EDITION} = "i3" ]] || [[ ${RELEASE} = "34" && ${EDITION} = "Cinnamon" ]] || [[ "${RELEASE}" < "39" && ${EDITION} = "Onyx" ]]; then
                 echo "ERROR! Unsupported combination"
                 echo "       Fedora ${RELEASE} ${EDITION} is not available, please choose another Release or Edition"

From 0f8331a9e3bb1d1be0d18308dfe504ee2c3df474 Mon Sep 17 00:00:00 2001
From: zenobit <zenobit@disroot.org>
Date: Thu, 4 Apr 2024 18:42:07 +0200
Subject: [PATCH 2/2] reviewdog.yml

---
 .github/workflows/reviewdog.yml | 55 +++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)
 create mode 100644 .github/workflows/reviewdog.yml

diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml
new file mode 100644
index 0000000000..68e700e6c9
--- /dev/null
+++ b/.github/workflows/reviewdog.yml
@@ -0,0 +1,55 @@
+name: reviewdog
+
+on: [push, pull_request, workflow_dispatch]
+
+#jobs:
+
+  #checks:
+    #name: Check scripts
+    #runs-on: ubuntu-latest
+
+    #strategy:
+      #matrix:
+        #package:
+        # - "**/*.sh" # checks all .sh files
+        #- quickget
+        #- quickemu
+    #steps:
+      #- uses: actions/checkout@v3
+      #- uses: cachix/install-nix-action@v17
+        #with:
+          #install_url: https://nixos.org/nix/install
+          #extra_nix_config: |
+            #auto-optimise-store = true
+            #experimental-features = nix-command flakes
+      #- run: nix run nixpkgs#shellcheck -- -S error ${{ matrix.package }}
+
+jobs:
+  quickemu-check:
+    name: runner / quickemu
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: shellcheck
+        uses: reviewdog/action-shellcheck@v1
+        with:
+          github_token: ${{ secrets.github_token }}
+          reporter: github-pr-review # Change reporter.
+          path: "." # Optional.
+          pattern: "quickemu" # Optional.
+          exclude: "./.git/*" # Optional.
+          check_all_files_with_shebangs: "false" # Optional.
+  quickget-check:
+    name: runner / quickget
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: shellcheck
+        uses: reviewdog/action-shellcheck@v1
+        with:
+          github_token: ${{ secrets.github_token }}
+          reporter: github-pr-review # Change reporter.
+          path: "." # Optional.
+          pattern: "quickget" # Optional.
+          exclude: "./.git/*" # Optional.
+          check_all_files_with_shebangs: "false" # Optional.