New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFE] Handling of Chrome-based web browsers #193

Open

robrwo opened this issue Apr 14, 2022 · 1 comment

robrwo commented Apr 14, 2022

Some Chrome-based web browsers like YaBrowser (Yandex), Brave and Vivaldi are reported as "chome" with the chrome version as the browser_version.

For example, Yandex browser

"Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/98.0.4758.132 YaBrowser/22.3.1.891 Yowser/2.5 Safari/537.36"

is treated as chome 98 instead of yandex 22.3.

Ideally, there should be a way to detect these browsers but doing so could break the detection.

It might be worth having a separate vendor and vendor_version methods that allows users to differentiate further details.

The text was updated successfully, but these errors were encountered:

Owner

oalders commented Apr 14, 2022

I'd be open to some kind of enhancement like this if someone were to take on the work. I'm happy to take on code reviews and shipping new releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment