Merge pull request #92 from oarepo/miroslavsimek/be-572-oarepo-publis…

…h-action-fails-if-record-does-not-have-file

fix: file check fails if files are not enabled for topic

oarepo_requests/types/publish_draft.py

@@ -108,19 +108,22 @@ def validate_topic(cls, identity: Identity, topic: Record) -> None:
         """
         topic_service = get_record_service_for_record(topic)
         topic_service.validate_draft(identity, topic["id"])
-        can_toggle_files = topic_service.check_permission(
-            identity, "manage_files", record=topic
-        )
-        draft_files = topic.files  # type: ignore
-        if draft_files.enabled and not draft_files.items():
-            if can_toggle_files:
-                my_message = _(
-                    "Missing uploaded files. To disable files for this record please mark it as metadata-only."
-                )
-            else:
-                my_message = _("Missing uploaded files.")
-
-            raise ma.ValidationError({"files.enabled": [my_message]})
+
+        # if files support is enabled for this topic, check if there are any files
+        if hasattr(topic, "files"):
+            can_toggle_files = topic_service.check_permission(
+                identity, "manage_files", record=topic
+            )
+            draft_files = topic.files  # type: ignore
+            if draft_files.enabled and not draft_files.items():
+                if can_toggle_files:
+                    my_message = _(
+                        "Missing uploaded files. To disable files for this record please mark it as metadata-only."
+                    )
+                else:
+                    my_message = _("Missing uploaded files.")
+
+                raise ma.ValidationError({"files.enabled": [my_message]})
 
     @classmethod
     def is_applicable_to(

setup.cfg

@@ -1,6 +1,6 @@
 [metadata]
 name = oarepo-requests
-version = 2.3.3
+version = 2.3.4
 description =
 authors = Ronald Krist <[email protected]>
 readme = README.md