Merge pull request #1852 from oasisprotocol/lw/fix-playwright

Fix playwright tests finding duplicate elements in closing modals
oasisprotocol · Feb 17, 2024 · 21e94f9 · 21e94f9
2 parents b88f079 + 4624afa
commit 21e94f9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/.changelog/1852.trivial.md b/.changelog/1852.trivial.md
@@ -0,0 +1 @@
+Fix playwright tests finding duplicate elements in closing modals
diff --git a/playwright/tests/toolbar.spec.ts b/playwright/tests/toolbar.spec.ts
@@ -46,6 +46,7 @@ test.describe('Profile tab', () => {
     await expect(page.getByText('Password updated.')).toBeVisible()
 
     await page.getByTestId('close-settings-modal').click()
+    await expect(page.getByTestId('close-settings-modal')).not.toBeVisible()
     await page.getByRole('button', { name: /Lock profile/ }).click()
     await page.getByPlaceholder('Enter your password here').fill(tempPassword)
     await page.getByRole('button', { name: /Unlock/ }).click()
@@ -63,6 +64,7 @@ test.describe('Profile tab', () => {
 
     // validate default password
     await page.getByTestId('close-settings-modal').click()
+    await expect(page.getByTestId('close-settings-modal')).not.toBeVisible()
     await page.getByRole('button', { name: /Lock profile/ }).click()
     await page.getByPlaceholder('Enter your password here').fill(password)
     await page.getByRole('button', { name: /Unlock/ }).click()
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix playwright tests finding duplicate elements in closing modals