Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror does not change dimensions for a different size error profile surface #22

Open
jureyherrera opened this issue Nov 7, 2023 · 0 comments
Open

Mirror does not change dimensions for a different size error profile surface #22

jureyherrera opened this issue Nov 7, 2023 · 0 comments

Comments

@jureyherrera
Copy link

jureyherrera commented Nov 7, 2023 •
edited
Loading

Unlike in SHADOWOUI, S4 does not change the optical element when using a different size error profile surface on SHADOW4 mirror widget.

S4 keeps the original dimensions and overlays the error profile, creating a bug in the ray beam. Example for a Ellipsoid mirror where a simulated error profile is smaller than original mirror dimensions:
image
OASYS workspace: KB_with_slope_errors_shadow4_test_JR.ows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jureyherrera