Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update delivery type service #65

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

yaraslau-kavaliou
Copy link
Contributor

@yaraslau-kavaliou yaraslau-kavaliou commented Aug 30, 2023

Ticket - https://oat-sa.atlassian.net/browse/REL-1167

Done some refactoring to fix cs-fixer issues

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.72% ⚠️

Comparison is base (b4a5818) 32.77% compared to head (0636368) 32.06%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #65      +/-   ##
=============================================
- Coverage      32.77%   32.06%   -0.72%     
  Complexity        44       44              
=============================================
  Files              3        3              
  Lines            180      184       +4     
=============================================
  Hits              59       59              
- Misses           121      125       +4     
Files Changed Coverage Δ
controller/ItemResultPreviewer.php 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yaraslau-kavaliou yaraslau-kavaliou force-pushed the feat/update-item-type-service branch 4 times, most recently from e4b3f40 to b1aecd0 Compare August 31, 2023 08:18
@yaraslau-kavaliou yaraslau-kavaliou force-pushed the feat/update-item-type-service branch from b1aecd0 to 0636368 Compare August 31, 2023 08:24
Copy link

@augustas augustas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, I just suggest a rename and updated version dependency of oat-sa/extension-tao-testqti

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Version

Target Version 1.4.0
Last version 1.3.3

There are 0 BREAKING CHANGE, 2 features, 0 fix

@yaraslau-kavaliou yaraslau-kavaliou merged commit c9864a2 into develop Sep 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants