Feat/AUT-3400/launching authoring by new configurable roles #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #396 +/- ##
=============================================
- Coverage 30.59% 30.35% -0.25%
- Complexity 817 827 +10
=============================================
Files 104 106 +2
Lines 2853 2906 +53
=============================================
+ Hits 873 882 +9
- Misses 1980 2024 +44 ☔ View full report in Codecov by Sentry. |
|
Hey, nice job! when you have time, could you please provide a demo???? |
|
Also, please, take a look at the ci jobs. Some of them are failing. |
Karol-Stelmaczonek
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- [] Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
|
@bartlomiejmarszal unit tests are failing |
Karol-Stelmaczonek
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
bartlomiejmarszal
requested review from
Karol-Stelmaczonek and
andreluizmachado
pribi
reviewed
Jan 3, 2024
test/unit/models/classes/Tool/Service/AuthoringLtiRoleServiceTest.php
Outdated
Show resolved
Hide resolved
bartlomiejmarszal
force-pushed
the
feat/AYT-3400/launching-authoring-by-new-configurable-roles
branch
from
e071f1f
to
28b4f2b
Compare
Version❕ Some commits are not using the conventional commits formats. They will be ignored in version management.
There are 0 BREAKING CHANGE, 2 features, 8 fixes |
andreluizmachado
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
Karol-Stelmaczonek
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
bartlomiejmarszal
deleted the
feat/AYT-3400/launching-authoring-by-new-configurable-roles
branch
andreluizmachado
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce:
Launch authoring tool using
devkitlinkLaunch without allowed roles:
http://purl.imsglobal.org/vocab/lis/v2/membership#Instructorhttp://purl.imsglobal.org/vocab/lis/v2/institution/person#Administratorhttp://purl.imsglobal.org/vocab/lis/v2/membership/ContentDeveloper#ContentDeveloperhttp://purl.imsglobal.org/vocab/lis/v2/membership/Administrator#DeveloperScreenshare.-.2024-01-04.11_49_14.AM.mp4