Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish to two solar tenants #402

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

mccar
Copy link
Contributor

@mccar mccar commented Mar 12, 2024

  • fix the issue with cache

@mccar mccar requested a review from vbyndych March 12, 2024 07:16
@mccar mccar requested a review from augustas March 12, 2024 07:22
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 31.47%. Comparing base (27390e7) to head (155db3e).

Files Patch % Lines
...ss/Repository/CachedPlatformKeyChainRepository.php 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #402   +/-   ##
==========================================
  Coverage      31.47%   31.47%           
  Complexity       841      841           
==========================================
  Files            106      106           
  Lines           2939     2939           
==========================================
  Hits             925      925           
  Misses          2014     2014           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Version

Target Version 15.17.0
Last version 15.16.0

There are 0 BREAKING CHANGE, 3 features, 0 fix

Copy link
Contributor

@augustas augustas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@mccar mccar merged commit c35f5bc into develop Mar 12, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants