Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing Reviewer role #405

Merged

Conversation

SultanSagi
Copy link
Contributor

Ticket: https://oat-sa.atlassian.net/browse/SOLAR-624

What's Changed

  1. Added missing Reviewer role to LTI 1p3 Content Developer

Dependencies PRs

How to test

  • Go to nextgen-app

  • install Workflow extension

  • Run the command: docker exec -it nextgen_tao bash

  • Inside run: php index.php '\oat\tao\scripts\SyncModels'

  • Log in TAO Portal with the user having Content Developer role

  • Select “Content Bank” card

  • Select an item

  • Click “Submit item for review “ button

Demo

image (1)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.47%. Comparing base (8168f6e) to head (579cad8).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #405   +/-   ##
==========================================
  Coverage      31.47%   31.47%           
  Complexity       841      841           
==========================================
  Files            106      106           
  Lines           2939     2939           
==========================================
  Hits             925      925           
  Misses          2014     2014           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pribi pribi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
flow-solved.webm

Copy link

github-actions bot commented Apr 8, 2024

Version

Target Version 15.19.1
Last version 15.19.0

There are 0 BREAKING CHANGE, 0 feature, 1 fix

@SultanSagi SultanSagi merged commit d5e5ab3 into develop Apr 9, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants