Feat/aut 3576/add restricted roles to role based context restrict access #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomiejmarszal
requested review from
tikhanovichA,
andreluizmachado,
pnal and
Karol-Stelmaczonek
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #409 +/- ##
=============================================
- Coverage 31.32% 31.21% -0.11%
Complexity 842 842
=============================================
Files 106 106
Lines 2953 2963 +10
=============================================
Hits 925 925
- Misses 2028 2038 +10 ☔ View full report in Codecov by Sentry. |
This was referenced Mar 21, 2024
Merged
pnal
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
andreluizmachado
approved these changes
Mar 25, 2024
Version
There are 0 BREAKING CHANGE, 4 features, 0 fix |
bartlomiejmarszal
deleted the
feat/AUT-3576/add-restricted-roles-to-RoleBasedContextRestrictAccess
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will decorate RoleBasedContextRestrictAccess with sections that we want to hide from defined roles.
This change requires:
oat-sa/tao-core#3987