Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove RegisterPortalTheme introduction #418

Merged
merged 10 commits into from
Jun 11, 2024
Merged

fix: remove RegisterPortalTheme introduction #418

merged 10 commits into from
Jun 11, 2024

Commits on Jun 10, 2024

  1. fix: remove RegisterPortalTheme introduction

    @bartlomiejmarszal
    bartlomiejmarszal committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    58ba40b View commit details
    Browse the repository at this point in the history

  2. fix: revert changes introdcued on instances with taoStyles installed

    @bartlomiejmarszal
    bartlomiejmarszal committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    00471a4 View commit details
    Browse the repository at this point in the history

  3. fix: Unregister

    @bartlomiejmarszal
    bartlomiejmarszal committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    83ff87d View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. fix: Unregister portal theme service and clear unused configs

    @bartlomiejmarszal
    bartlomiejmarszal committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    c03feec View commit details
    Browse the repository at this point in the history

  2. fix: Provide current theme in Authoring controller. Create PortalThem… 

    …eDetailProvider. Add `themeDetailsProviders` with PortalThemeDetailProvider
    @bartlomiejmarszal
    bartlomiejmarszal committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    e1d1c21 View commit details
    Browse the repository at this point in the history

  3. fix: UnregisterLtiPortal can now define current theme if not defined.

    @bartlomiejmarszal
    bartlomiejmarszal committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    fe2227f View commit details
    Browse the repository at this point in the history

  4. fix: UnregisterLtiPortal making sure config for PersistenceThemeServi… 

    …ce is valid. PortalThemeDetailProvider will return empty sting if session not from portal
    @bartlomiejmarszal
    bartlomiejmarszal committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    5cd185a View commit details
    Browse the repository at this point in the history

  5. fix: Remove setting current theme from controller. Remove RegisterPor… 

    …talTheme. Remove reference to RegisterPortalTheme in manifest and replace it with RegisterPortalThemeDetailProvider
    @bartlomiejmarszal
    bartlomiejmarszal committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    8253806 View commit details
    Browse the repository at this point in the history

  6. fix: We want to always include PortalThemeDetailProvider to recognise… 

    … portal entry
    @bartlomiejmarszal
    bartlomiejmarszal committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    04f5d0c View commit details
    Browse the repository at this point in the history

  7. fix: When upgrading from taoLti v15.19.2 we will not pollute Persiste… 

    …nceThemeService config
    @bartlomiejmarszal
    bartlomiejmarszal committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    65216fc View commit details
    Browse the repository at this point in the history