Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS configuration in README does not work #37

Open
johnmaguire opened this issue Jun 22, 2022 · 0 comments
Open

TLS configuration in README does not work #37

johnmaguire opened this issue Jun 22, 2022 · 0 comments

Comments

@johnmaguire
Copy link

johnmaguire commented Jun 22, 2022

https://github.com/oauth2-proxy/mockoidc/blob/main/README.md?plain=1#L43-L53

This doesn't work because RunTLS calls net.Listen instead of a tls.Listen: https://github.com/oauth2-proxy/mockoidc/blob/main/mockoidc.go#L99

This example suffers from the same issue if it's trying to demonstrate TLS (which the non-nil tlsConfig led me to believe) - https://github.com/oauth2-proxy/mockoidc/blob/main/README.md?plain=1#L160-L177

Changing the last example to use tls.Listen produces a working TLS OpenID Provider.

Thanks for this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant