Apply suggestions from code review

obi1kenobi · Oct 16, 2024 · 6d540ee · 6d540ee
1 parent 69c20ac
commit 6d540ee
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 4 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -16,7 +16,7 @@ exclude = [".github/", "brand/", "scripts/", "test_crates/", "test_outputs/", "t
 
 [dependencies]
 trustfall = "0.7.1"
-trustfall_rustdoc = { version = "0.16.2", default-features = false, features = ["v28", "v29", "v30", "v32", "v33", "v34", "rayon", "rustc-hash"] }
+trustfall_rustdoc = { version = "0.16.2", default-features = false, features = ["v28", "v29", "v30", "v32", "v33", "v34", "v35", "rayon", "rustc-hash"] }
 clap = { version = "4.5.17", features = ["derive", "cargo"] }
 serde_json = "1.0.128"
 anyhow = "1.0.89"

diff --git a/src/lints/declarative_macro_missing.ron b/src/lints/declarative_macro_missing.ron
@@ -26,7 +26,6 @@ SemverQuery(
                 item {
                     ... on Macro {
                         visibility_limit @filter(op: "=", value: ["$public"])
-                        public_api_eligible @filter(op: "=", value: ["$true"])
                         name @filter(op: "=", value: ["%name"])
                     }
                 }

diff --git a/test_crates/declarative_macro_missing/new/src/lib.rs b/test_crates/declarative_macro_missing/new/src/lib.rs
@@ -1,3 +1,15 @@
 macro_rules! will_no_longer_be_exported {
     () => {};
-}
+}
+
+#[doc(hidden)]
+#[macro_export]
+macro_rules! became_doc_hidden {
+    () => {};
+}
+
+#[doc(hidden)]
+#[macro_export]
+macro_rules! always_doc_hidden {
+    () => {};
+}
diff --git a/test_crates/declarative_macro_missing/old/src/lib.rs b/test_crates/declarative_macro_missing/old/src/lib.rs
@@ -10,4 +10,15 @@ macro_rules! will_no_longer_be_exported {
 
 macro_rules! textual_scope_macro_removed {
     () => {};
-}
+}
+
+#[macro_export]
+macro_rules! became_doc_hidden {
+    () => {};
+}
+
+#[doc(hidden)]
+#[macro_export]
+macro_rules! always_doc_hidden {
+    () => {};
+}