Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RustdocCommand progress (when silence is false) does not respect configured stderr #761

Open
suaviloquence opened this issue Apr 16, 2024 · 0 comments

Comments

@suaviloquence
Copy link
Contributor

suaviloquence commented Apr 16, 2024

This is a little more nebulous than I thought - it works when RustdocCommand::silence is true, but when it is false, since we just forward the rustdoc err stream to stderr (actual tty stderr, not GlobalConfig::stderr), we're not currently using the configured stderr for the rustdoc progress stream. We can redirect it using Command::spawn and a thread that acts as a pipe between the child process stderr and our stderr if we want. Do you think a library user would expect this behavior? That is, would they expect the rustdoc progress output to go through the cargo-semver-checks' configured stderr. I'm leaning towards yes, but it will add more complexity to the function because we have to use threads.

Originally posted by @suaviloquence in #737 (comment)

Doesn't require immediate action; just something to be aware of in the future. Would a library user expect this rustdoc progress to be outputted to the configured stderr? Is there a way to do this without a thread that pipes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant