-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for repositories with git submodules #927
Comments
Interesting, we've never had to work with submodules before so this wasn't even on our radar. Thanks for opening this issue! If I understood correctly, this is an issue with any argument passed to |
It happens with any revision passed to I think the git clone command would just need to include |
@Byron if you have a sec, I'd love your help. I think you kindly contributed our I wasn't able to figure out how to update the |
Thanks for letting me know! From there one has to see how Unfortunately I can't implement it for you, but believe that with that function it will be possible to discover submodules and either see their URLs to clone from, or open their repos to extract objects from their clones. Clones would be interesting as an active submodule would then need to register itself in the git configuration, and that's not easily done yet with The easiest way to clone with submodules would be to use the For executing Here is the summary of what I would do to keep it simple:
I hope that helps. |
Thank you for your prompt reply @Byron, I appreciate it! @spearman it seems this would unfortunately take a decent bit of work to support, and isn't the easy fix we were hoping it would be. I'd happily take a well-tested PR for it, but I'm afraid I can't prioritize building it myself at the moment. I'm sorry — I know that isn't the answer you were hoping for. If the use case that needs this functionality is of a commercial nature, I'd be happy to chat about possible options there. |
Steps to reproduce the bug with the above code
I have a crate that includes several workspace members as git submodules in the repository. I want to check if I need to bump the version before committing.
Actual Behaviour
I run:
This appears to clone the revision into the semver-checks target directory, but it hasn't cloned any of the workspace submodules, so it fails during cargo update with
failed to load source for dependency
and gives a path to the submodule manifest that doesn't exist because it hasn't been initialized.Is there a way to make this work?
Expected Behaviour
Finishes running without error.
Generated System Information
System information:
Software version
cargo-semver-checks 0.35.0
Operating system
Linux 6.1.96
Command-line
cargo version
Compile time information
Cargo build configuration:
[net]
git-fetch-with-cli = true
Build Configuration
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: