Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent API for line and column numbering #34

Open
object88 opened this issue Feb 7, 2018 · 0 comments
Open

Inconsistent API for line and column numbering #34

object88 opened this issue Feb 7, 2018 · 0 comments

Comments

@object88
Copy link
Owner

object88 commented Feb 7, 2018

Workspace APIs such as LocateDeclaration expect a 1s based numbering system. ChangeFile expects a 0s based system.

package foo
var Foof int = 1
func Foo() int {
	return Foof
}

Calling LocateDeclaration for Foof in return Foof is (4, 9). The same for ChangeFile is (3, 8).

The numbering systems must be consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@object88