Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check a puzzle format locally #1581

Closed
volodya-lombrozo opened this issue Dec 19, 2022 · 6 comments
Closed

Check a puzzle format locally #1581

volodya-lombrozo opened this issue Dec 19, 2022 · 6 comments
Assignees
Labels
Milestone

Comments

@volodya-lombrozo
Copy link
Member

I quite often face with the problem of the correct formatting of a puzzle in the code. I've read notation, but some problems can reveal anyway (Short description, Wrong puzzle time, etc). I've found only the single way to check the puzzle format - to push.
Is it exist any other way to check a puzzle format before pushing it?

@yegor256
Copy link
Member

yegor256 commented Dec 19, 2022

@volodya-lombrozo we can add the checking of puzzle formatting into the pom.xml, using exec-maven-plugin. Otherwise, we can create a new Maven plugin for that. Let's do what's the simplest: the exec. Later, we can think about making a special plugin.

@yegor256
Copy link
Member

@volodya-lombrozo in the meantime, you can check formatting locally. You need to install pdd and then run:

$ pdd -f /dev/null

@Graur
Copy link
Contributor

Graur commented May 4, 2023

@yegor256 @volodya-lombrozo I think the simplest solution seems less significant. This will not save us from installing all the pdd dependencies on the local machine. I think the best way is to create a Maven plugin (as Yegor already mentioned). I also created issue cqfn/pdd#219 about it in the pdd repository.

@yegor256
Copy link
Member

yegor256 commented May 6, 2023

@volodya-lombrozo I agree, we should wait for the Maven plugin made by the PDD "team"

@mximp mximp added this to the M3 milestone May 29, 2023
@Graur
Copy link
Contributor

Graur commented Aug 11, 2023

@yegor256 @volodya-lombrozo I believe we can close it

@Graur Graur modified the milestones: M3, Routine Aug 11, 2023
@volodya-lombrozo
Copy link
Member Author

Since we are waiting for cqfn/pdd#219 to be completed, I agree that we can close this issue and reference it next time if we have the similar questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants