add coverage tooling #152
Merged
add coverage tooling #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cinxmo
reviewed
Nov 14, 2023
| @@ -25,9 +25,15 @@ | |||
| "dev": "tsx watch ./src/preview.ts", | |||
| "build": "rm -rf dist && ./bin/observable.ts build", | |||
| "test": "yarn test:mocha && yarn test:lint", | |||
| "test:coverage": "npx c8 yarn test:mocha", | |||
There was a problem hiding this comment.
this is interesting - a combination of npx and yarn?
There was a problem hiding this comment.
npx loads c8, which then runs yarn test:mocha :)
There was a problem hiding this comment.
for more see observablehq/plot#1818
There was a problem hiding this comment.
interesting... what's the benefit of this over npm i c8 --save-dev and then modifying "test:coverage": "c8 yarn test:mocha"? or yarn add c8 --dev
There was a problem hiding this comment.
benefit is we don't install c8 if we don't check coverage
cinxmo
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an exact copy of what we have in Plot (with the addition of ts files from src/).
Could help to increase coverage (#86).
calling
yarn test:coverageoutputs a coverage report in text format; it also creates a report in the lcov format, which can be used to display coverage gutters, for example.Here's what the coverage looks like in text:
And the coverage gutters:
