A channel of explicit symbols does not show in the tip nor has a legend

closes #2237
observablehq · Nov 19, 2024 · d514313 · d514313
1 parent ff7d83c
commit d514313
Show file tree

Hide file tree

Showing 4 changed files with 396 additions and 2 deletions.
diff --git a/src/marks/tip.js b/src/marks/tip.js
@@ -347,8 +347,8 @@ function getSourceChannels(channels, scales) {
     if ((key === "x" || key === "y") && channels.geometry) continue; // ignore x & y on geo
     const source = getSource(channels, key);
     if (source) {
-      // Ignore color channels if the values are all literal colors.
-      if (source.scale == null && source.defaultScale === "color") continue;
+      // Ignore color/symbol channels if the values are all literal colors/symbols.
+      if (source.scale == null && ["color", "symbol"].includes(source.defaultScale)) continue;
       sources[key] = source;
     }
   }