fix rendering of one-dimensional rects (#817)

observablehq · Mar 21, 2022 · e466abe · e466abe
1 parent db209c5
commit e466abe
Show file tree

Hide file tree

Showing 4 changed files with 90 additions and 1 deletion.
diff --git a/src/marks/rect.js b/src/marks/rect.js
@@ -50,7 +50,7 @@ export class Rect extends Mark {
     const {insetTop, insetRight, insetBottom, insetLeft, dx, dy, rx, ry} = this;
     return create("svg:g")
         .call(applyIndirectStyles, this, dimensions)
-        .call(applyTransform, x, y, dx, dy)
+        .call(applyTransform, X1 && X2 ? x : null, Y1 && Y2 ? y : null, dx, dy)
         .call(g => g.selectAll()
           .data(index)
           .enter()

diff --git a/test/output/rectBand.svg b/test/output/rectBand.svg
diff --git a/test/plots/index.js b/test/plots/index.js
@@ -120,6 +120,7 @@ export {default as randomBins} from "./random-bins.js";
 export {default as randomBinsXY} from "./random-bins-xy.js";
 export {default as randomQuantile} from "./random-quantile.js";
 export {default as randomWalk} from "./random-walk.js";
+export {default as rectBand} from "./rect-band.js";
 export {default as seattlePrecipitationRule} from "./seattle-precipitation-rule.js";
 export {default as seattleTemperatureBand} from "./seattle-temperature-band.js";
 export {default as seattleTemperatureCell} from "./seattle-temperature-cell.js";

diff --git a/test/plots/rect-band.js b/test/plots/rect-band.js
@@ -0,0 +1,16 @@
+import * as Plot from "@observablehq/plot";
+
+export default async function() {
+  return Plot.plot({
+    y: {
+      type: "band",
+      domain: "ABC",
+      grid: true
+    },
+    marks: [
+      Plot.frame(),
+      Plot.barX({length: 1}, {x1: [0], x2: [1], fill: "cyan", mixBlendMode: "multiply"}),
+      Plot.rectX({length: 1}, {x1: [0], x2: [1], fill: "magenta", mixBlendMode: "multiply"})
+    ]
+  });
+}