Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erroneous type definition for the tip {maxRadius} option #2134

Closed
Fil opened this issue Aug 14, 2024 · 1 comment
Closed

Erroneous type definition for the tip {maxRadius} option #2134

Fil opened this issue Aug 14, 2024 · 1 comment
Labels
bug Something isn’t working

Comments

@Fil
Copy link
Contributor

Fil commented Aug 14, 2024

If you say tip: {maxRadius: 100}, the maxRadius option is correctly passed through to the pointer, affecting the interaction as expected; however our typescript defs reject it.

Capture d’écran 2024-08-14 à 18 50 15
@Fil Fil added the bug Something isn’t working label Aug 14, 2024
@Fil Fil mentioned this issue Aug 14, 2024
Merged
4 tasks
Fil added a commit that referenced this issue Nov 21, 2024
@Fil
tip: {…} can contain PointerOptions
4bd99fe 
closes #2134
@Fil Fil mentioned this issue Nov 21, 2024
Closed
@mbostock
Copy link
Member

Fixed in #2132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn’t working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tip: {…} can contain PointerOptions observablehq/plot
2 participants
@Fil @mbostock