Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waffles can overflow the frame #2256

Open
mbostock opened this issue Nov 26, 2024 · 0 comments
Open

Waffles can overflow the frame #2256

mbostock opened this issue Nov 26, 2024 · 0 comments
Labels
bug Something isn’t working

Comments

@mbostock
Copy link
Member

As noted in #2132 (comment):

untitled - 2024-11-20T172228 394

Plot.waffleY([0.5, 2, 4], {x: null, fill: Plot.indexOf}).plot({color: {type: "categorical"}})

Above, the y-scale only extends from [0, 6.5], but the waffle visually extends to y = 7.5… that’s because here each cell of the waffle is 3 y-units tall, as there are three columns. We’d need the waffle mark to provide a hint to the y scale that the domain needs to be taller than the apparent value from the y1 and y2 channels.

@mbostock mbostock added the bug Something isn’t working label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Projects
None yet
Development

No branches or pull requests

1 participant