Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning / logging system? #536

Closed
Fil opened this issue Sep 6, 2021 · 1 comment · Fixed by #751
Closed

Warning / logging system? #536

Fil opened this issue Sep 6, 2021 · 1 comment · Fixed by #751
Labels
enhancement New feature or request question Further information is needed

Comments

@Fil
Copy link
Contributor

Fil commented Sep 6, 2021

In some cases we'd want Plot to warn the user about some kind of misconfiguration or unfit data that causes issues.

This meta-issue tries to capture all the cases when we'd want such a logging/warning system, and discussions on how they could be rendered.

A design issue is to know when it would be appropriate to display this — with a distinction between the case in which the user is actively coding (data exploration, development), vs. when the user passively consumes a chart, and the developer might want the chart to be more robust to errors.

@mbostock
Copy link
Member

mbostock commented Sep 6, 2021

I think we should also consider throwing errors that prevent the chart from rendering, forcing the user to clarify something, in cases where we do not think we can make a reasonable interpretation of the chart specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants