diff --git a/src/api/views/auth_factor.py b/src/api/views/auth_factor.py index 38116157..d4f0c6a1 100644 --- a/src/api/views/auth_factor.py +++ b/src/api/views/auth_factor.py @@ -65,7 +65,11 @@ def check_if_exists(self, request: Request[User]): serializer.is_valid(raise_exception=True) return Response( - self.get_queryset().filter(**serializer.validated_data).exists() + { + "auth_factor_exists": self.get_queryset() + .filter(**serializer.validated_data) + .exists() + } ) @action(detail=False, methods=["get"]) diff --git a/src/api/views/auth_factor_test.py b/src/api/views/auth_factor_test.py index 6ae16453..3d96f7c4 100644 --- a/src/api/views/auth_factor_test.py +++ b/src/api/views/auth_factor_test.py @@ -282,7 +282,7 @@ def test_check_if_exists(self): }, ) - assert response.json() is True + self.assertDictEqual(response.json(), {"auth_factor_exists": True}) def test_get_otp_secret(self): """Can successfully generate a OTP provisioning URI.""" diff --git a/src/api/views/klass.py b/src/api/views/klass.py index e7f25c61..5a5058f8 100644 --- a/src/api/views/klass.py +++ b/src/api/views/klass.py @@ -16,6 +16,7 @@ class ClassViewSet(_ClassViewSet): http_method_names = ["get", "post", "patch", "delete"] + # pylint: disable-next=missing-function-docstring def get_permissions(self): # Only bulk-partial-update allowed for classes. if self.action == "bulk": @@ -31,12 +32,14 @@ def get_permissions(self): return super().get_permissions() + # pylint: disable-next=missing-function-docstring def get_serializer_class(self): if self.action in ["create", "partial_update", "bulk"]: return WriteClassSerializer return ReadClassSerializer + # pylint: disable-next=missing-function-docstring def get_queryset(self): if self.action in ["retrieve", "list"]: return super().get_queryset() @@ -48,6 +51,7 @@ def get_queryset(self): else teacher.classes.filter(teacher=teacher) ) + # pylint: disable-next=missing-function-docstring def destroy(self, request, *args, **kwargs): klass = self.get_object()