Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor agreement #127

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Contributor agreement #127

merged 4 commits into from
Jul 24, 2024

Conversation

Ridwanah
Copy link
Contributor

@Ridwanah Ridwanah commented Jul 23, 2024

I followed the contributor agreement instructions and I added my email to the end of CONTRIBUTING.md. I accidentally committed some unnecessary files like ds_store, which you can discard.


This change is Reviewable

@faucomte97
Copy link
Contributor

No worries @Ridwanah, you can go ahead and revert these changes yourself - the pipeline requires only CONTRIBUTING.md to be changed - please revert all changes other than the ones to that file.

@Ridwanah
Copy link
Contributor Author

I reverted the other changes I made. The only change left is adding my email.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 5 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ridwanah)

@faucomte97
Copy link
Contributor

This pull request looks good @Ridwanah, we're almost there! You should have just received an email that you need to reply to with the response mentioned in the guide so we can verify you own the email. Once we receive your response, I will merge in this PR and you'll be an official Code for Life contributor!
And I will then start reviewing your other PR in rapid router 😄

@faucomte97 faucomte97 merged commit cffee0e into ocadotechnology:main Jul 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants