Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #71

Merged
merged 3 commits into from
Jan 19, 2024
Merged

[email protected] #71

merged 3 commits into from
Jan 19, 2024

Conversation

akurtle
Copy link
Contributor

@akurtle akurtle commented Jan 19, 2024

This change is Reviewable

@faucomte97
Copy link
Contributor

Hi @akurtle! Glad to see you want to become a contributor! 🥳
I think you just missed a step - if you look again at step 1 part ii, you need to make sure your email address on Github isn't private:

You cannot use a private/noreply email address. If you have a GitHub account, this is enabled by default and can be turned off at Settings > Emails > Keep my email addresses private.

Let me know once you've turned the setting off and I can re-run the pipeline for you 😃

@akurtle
Copy link
Contributor Author

akurtle commented Jan 19, 2024

Hello! I have turned the setting off, the email should be public now

@faucomte97
Copy link
Contributor

Hi @akurtle, thanks for that!

I think though that because the last commit on your main branch was signed with the private email our check is still failing, so there's just one more thing you need to do, sorry!

Can you try making a very small commit, something like adding a space after your email address, and then reverting that commit, so the contents of your PR stay the same but the signature is updated? That should work.

@akurtle
Copy link
Contributor Author

akurtle commented Jan 19, 2024

Hi, I did it right now, please let me know if thats alright!

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @akurtle)

@faucomte97
Copy link
Contributor

Hi @akurtle, awesome that worked!

You should have received an verification email. Please follow the instructions in that email and that should be the last step to confirming your contributor status! 🥳

@faucomte97 faucomte97 merged commit 8f38cf4 into ocadotechnology:main Jan 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants