Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level Editor layout is wonky #1543

Closed
faucomte97 opened this issue Nov 28, 2023 · 4 comments
Closed

Level Editor layout is wonky #1543

faucomte97 opened this issue Nov 28, 2023 · 4 comments

Comments

@faucomte97
Copy link
Contributor

faucomte97 commented Nov 28, 2023

Describe the bug
The Level Editor layout has become wonky. The grid has grown in size so it no longer fits in the window and the bin has moved closer to the centre of the window.
Additionally, when moving scenery assets onto the grid, the mouse cursor isn't in line with the grid and where the asset actually ends up - most likely a byproduct of the grid being oversized.

This is a side-effect of #1516. Reverting the code to what it was before that change "fixes" it, although the original issue comes back whereby the grid is cut off. A solution needs to be found to fix both problems.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to the level editor.
  2. Notice that the grid no longer fits in the window and the bin isn't in the bottom-right corner anymore.
  3. Click on the "Scenery" tab on the side.
  4. Click on any scenery asset.
  5. Drag the asset from the corner of the grid to any point of the grid and notice that where your cursor is doesn't match where the asset ends up.

Expected behaviour
The grid should fit within the window and the bin should go back to the bottom-right of the window.
Assets that are added to the map should be in line with where the cursor is.

Screenshots
Screenshot from 2023-11-28 13-59-37

Desktop (please complete the following information):
Probably all (double-check)

@faucomte97 faucomte97 added bug good first issue Good issue for first time contributor volunteers Tasks that can be picked up by anyone labels Nov 28, 2023
@faucomte97 faucomte97 removed the good first issue Good issue for first time contributor label Dec 22, 2023
@SKairinos
Copy link
Contributor

Can't drag objects into bin when bin is below grid
Private Zenhub Video

@SKairinos
Copy link
Contributor

I propose the following fix, we should be able to drag elements off the grid and release it into the bin. However, if the element is released off the grid and it's not over the bin, the element should be placed at max x if it's x coordinate is over the max and max y if it's y coordinate is over the max

@faucomte97 faucomte97 removed the volunteers Tasks that can be picked up by anyone label May 15, 2024
@lauracumming
Copy link

lauracumming commented May 21, 2024

  • production approved

@lauracumming
Copy link

lauracumming commented May 21, 2024

  • Check Cookie banner: banner loads, categories in the right order, cookies disabled by default
  • Check Rapid Router: game loads, can solve a level, can save a workspace, can create a level, can save a level, scores get saved, scoreboard loads
  • Check OS on browserstack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants