Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reviewed translations to Rapid Router #1732

Closed
4 of 9 tasks
lauracumming opened this issue Sep 16, 2024 · 11 comments · Fixed by #1737
Closed
4 of 9 tasks

Add reviewed translations to Rapid Router #1732

lauracumming opened this issue Sep 16, 2024 · 11 comments · Fixed by #1737
Assignees

Comments

@lauracumming
Copy link

lauracumming commented Sep 16, 2024

Task Description

Add newly verified translations for the Blockly blocks to the game and enable them in the language dropdown.

image

Acceptance Criteria

  • Polish (priority)
  • Brazilian Portuguese
  • Italian
  • Punjabi
  • Urdu
  • Russian
  • Bulgarian (priority)

Good Places to Start

Directory for the language files: https://github.com/ocadotechnology/rapid-router/tree/master/game/static/game/js/blockly/msg/js

Example PR which added a new block translation to certain languages: #1712

Analytics Requirements

  • Track usage of language buttons

Copywrite Requirements

@lauracumming lauracumming added the volunteers Tasks that can be picked up by anyone label Sep 16, 2024
@henamistry-ot
Copy link

hello

@SKairinos SKairinos self-assigned this Sep 30, 2024
@faucomte97 faucomte97 removed the volunteers Tasks that can be picked up by anyone label Sep 30, 2024
@SKairinos
Copy link
Contributor

Seems that we cannot do Punjabi as it's not one of Blockly's default translated languages. At least for our version of Blockly

@SKairinos
Copy link
Contributor

italian, no. 17, is missing "do"
Image

@faucomte97
Copy link
Contributor

@SKairinos Can you double check with Marco (who did the translations) that the order of words for 19. and 20. matches the order in English - ie, the variable name needs to be put in the first input, and the value in the second input. Some languages, especially Romance languages, tend to invert the order of those words in the "obvious" translation so it might have to be tweaked.

@SKairinos
Copy link
Contributor

@SKairinos
Copy link
Contributor

Cannot do Urdu as format of strings is not consistent
Image

@SKairinos
Copy link
Contributor

@faucomte97, I need marco's email

@SKairinos SKairinos linked a pull request Oct 2, 2024 that will close this issue
@faucomte97 faucomte97 reopened this Oct 4, 2024
@faucomte97
Copy link
Contributor

LGTM

1 similar comment
@lauracumming
Copy link
Author

LGTM

@faucomte97
Copy link
Contributor

LGTM (prod)

@lauracumming
Copy link
Author

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants