Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix icon colors #1711

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fix: fix icon colors #1711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd8c822
use color inversions instead of multiple svgs
evemartin Aug 29, 2024
8df023d
remove some unnecessary attributes
evemartin Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion game/static/game/css/game.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ option {

#tabs #blockly_tab img,
#tabs #python_tab img {
filter: none;
filter: invert(1);
}

#right {
Expand Down
2 changes: 1 addition & 1 deletion game/static/game/image/icons/blockly.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions game/static/game/image/icons/python.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 0 additions & 8 deletions game/static/game/image/icons/python_black.svg
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions game/static/game/image/icons/python_white.svg
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions game/templates/game/game.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@
<div id="python_tab" class="tab selectable {% if not level.pythonEnabled %}hidden{% endif %}">
<input type="radio" name="tabs" id="python_radio">
<label for="python_radio">
<img src="{% static 'game/image/icons/python_white.svg' %}">
<img src="{% static 'game/image/icons/python.svg' %}">
<span>{% trans "Python Den" %}</span>
</label>
</div>
Expand Down Expand Up @@ -346,7 +346,7 @@ <h3>{% trans "Python Program" %}
<div>
<div id="pythonIntro">{% trans "Use the Python editor below to design your program, and then click play to try it out!" %}</div>
<button class="navigation_button_portal long_button" id="van_commands_help">
<img src="{% static 'game/image/icons/python_black.svg' %}">
<img src="{% static 'game/image/icons/python.svg' %}">
<span>{% trans "Commands" %}</span>
</button>
</div>
Expand Down
Loading