Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move obus to ocaml-community #29

Open
meadofpoetry opened this issue Jun 18, 2019 · 20 comments
Open

Move obus to ocaml-community #29

meadofpoetry opened this issue Jun 18, 2019 · 20 comments

Comments

@meadofpoetry
Copy link

meadofpoetry commented Jun 18, 2019

Propose to move a project to ocaml-community

Project name: obus

Initial author(s): Jérémie Dimino (diml)

Current URL: https://github.com/diml/obus

License: BSD

Description: Pure OCaml implementation of D-Bus IPC protocol

Do the current maintainer(s) agree with the move: yes (https://discuss.ocaml.org/t/should-obus-be-moved-to-ocaml-community/3946)

New maintainer: I could take it so far (Eugene Bulavin @Freyr666)

@pmetzger
Copy link
Member

This seems fine by me. @diml seems to agree as well. If @diml could handle the move of the repository to ocaml-community, I will then give @Freyr666 full rights over it as the new maintainer.

@ghost
Copy link

ghost commented Jun 20, 2019

I just transferred the repository to ocaml-community

@pmetzger
Copy link
Member

@Freyr666 I've added you as a collaborator. You should now be able to go through the checklist in the README (esp. section 4 of "How do I submit a package for inclusion?").

@pmetzger
Copy link
Member

Oh, and @Freyr666, you may want to submit your updates initially as pull requests just so that other people get a chance to glance at them.

@pmetzger
Copy link
Member

@Freyr666 how is this going?

@meadofpoetry
Copy link
Author

@pmetzger I was a bit busy this week. I'll start with updating in the next few days.

@pmetzger
Copy link
Member

@Freyr666 Thanks! Do let us know as you make progress.

@meadofpoetry
Copy link
Author

@pmetzger Ok, so I've made a 1.2.0 release. I'll made as few changes as was possible, so I'll publish it and let the people test it, I suppose. I think this issue might be closed.

@pmetzger
Copy link
Member

pmetzger commented Jul 4, 2019

@Freyr666 Were all the steps in the guide followed? I don't see a CODEOWNERS file for example.

@pmetzger pmetzger reopened this Jul 4, 2019
@meadofpoetry
Copy link
Author

meadofpoetry commented Jul 4, 2019

@pmetzger Ah, yeah, sorry, I'll add it right now. Whom else should I add to CODEOWNERS?

@pmetzger
Copy link
Member

pmetzger commented Jul 4, 2019

Yourself, @diml and myself would be a good start. You should also make sure all the other steps in the meta README are followed.

@meadofpoetry
Copy link
Author

@pmetzger ok, I've added it. How could I turn CI on? I have a travis file, but not sure what to do next.

@pmetzger
Copy link
Member

pmetzger commented Jul 4, 2019

I'll turn Travis on.

@pmetzger
Copy link
Member

pmetzger commented Jul 4, 2019

It's on already, it just doesn't have a badge...

https://travis-ci.com/ocaml-community/obus

@pmetzger
Copy link
Member

pmetzger commented Jul 4, 2019

I've now added a build badge to README.md

@pmetzger
Copy link
Member

pmetzger commented Jul 5, 2019

...and the build passes.

BTW, in addition to going through the README.md checklist, we should probably go through the open issues, there aren't many.

@meadofpoetry
Copy link
Author

@pmetzger Well, I've checked the references (I hope I didn't miss any) and published the packages. I haven't updated the 1.1.5 version, since it wasn't hosted on github.

As for the issues, should the outdated issues be closed? I don't see any valid issues safe for the last one, which I would like to address in the next release.

@pmetzger
Copy link
Member

pmetzger commented Jul 6, 2019

Cool on the new release. Did you update the opam repo as well?

On the open issues, if any issue is clearly outdated, then post something to the issue saying "was this fixed" (or the equivalent) and if there's no reply to the contrary, close it after a couple of days.

@meadofpoetry
Copy link
Author

@pmetzger >Did you update the opam repo as well?

I updated paths in obus.1.1.6, obus.1.1.7, obus.1.1.8 packages, and published obus.1.2.0. I didn't touch the obus.1.1.5 since it wasn't hosted on github.

@pmetzger
Copy link
Member

pmetzger commented Jul 6, 2019

I updated paths in obus.1.1.6, obus.1.1.7, obus.1.1.8 packages, and published obus.1.2.0. I didn't touch the obus.1.1.5 since it wasn't hosted on github.

Reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants