From 554f6a837caffc974509a4489aa321ccc647ef48 Mon Sep 17 00:00:00 2001
From: Vesa Karvonen <vesa.a.j.k@gmail.com>
Date: Sun, 26 Jan 2025 20:40:53 +0000
Subject: [PATCH] Rewrite `Bounded_q` bench using two `Sem`s

---
 bench/bench_bounded_q.ml | 67 +++++++++++++++++++---------------------
 1 file changed, 31 insertions(+), 36 deletions(-)

diff --git a/bench/bench_bounded_q.ml b/bench/bench_bounded_q.ml
index b94112bc..3fafe3e2 100644
--- a/bench/bench_bounded_q.ml
+++ b/bench/bench_bounded_q.ml
@@ -17,20 +17,18 @@ end = struct
   type 'a t = {
     lock : Lock.t;
     queue : 'a Queue.t;
-    capacity : int;
-    not_empty : Lock.Condition.t;
-    not_full : Lock.Condition.t;
+    capacity : Sem.t;
+    length : Sem.t;
   }
 
-  let create ?(capacity = Int.max_int) () =
+  let create ?(capacity = Sem.max_value) () =
     if capacity < 0 then invalid_arg "negative capacity"
     else
       let lock = Lock.create ~padded:true ()
       and queue = Queue.create () |> Multicore_magic.copy_as_padded
-      and not_empty = Lock.Condition.create ~padded:true ()
-      and not_full = Lock.Condition.create ~padded:true () in
-      { lock; queue; capacity; not_empty; not_full }
-      |> Multicore_magic.copy_as_padded
+      and capacity = Sem.create ~padded:true capacity
+      and length = Sem.create ~padded:true 0 in
+      { lock; queue; capacity; length } |> Multicore_magic.copy_as_padded
 
   let is_empty t =
     Lock.acquire t.lock;
@@ -38,48 +36,45 @@ end = struct
     Lock.release t.lock;
     result
 
-  let is_full_unsafe t = t.capacity <= Queue.length t.queue
-
   let push t x =
-    Lock.acquire t.lock;
-    match
-      while is_full_unsafe t do
-        Lock.Condition.wait t.not_full t.lock
-      done
-    with
+    Sem.acquire t.capacity;
+    match Lock.acquire t.lock with
     | () ->
         Queue.push x t.queue;
-        let n = Queue.length t.queue in
         Lock.release t.lock;
-        if n = 1 then Lock.Condition.broadcast t.not_empty
+        Sem.release t.length
     | exception exn ->
-        Lock.release t.lock;
-        raise exn
+        let bt = Printexc.get_raw_backtrace () in
+        Sem.release t.capacity;
+        Printexc.raise_with_backtrace exn bt
 
   let pop t =
-    Lock.acquire t.lock;
-    match
-      while Queue.length t.queue = 0 do
-        Lock.Condition.wait t.not_empty t.lock
-      done
-    with
+    Sem.acquire t.length;
+    match Lock.acquire t.lock with
     | () ->
-        let n = Queue.length t.queue in
         let elem = Queue.pop t.queue in
         Lock.release t.lock;
-        if n = t.capacity then Lock.Condition.broadcast t.not_full;
+        Sem.release t.capacity;
         elem
     | exception exn ->
-        Lock.release t.lock;
-        raise exn
+        let bt = Printexc.get_raw_backtrace () in
+        Sem.release t.length;
+        Printexc.raise_with_backtrace exn bt
 
   let pop_opt t =
-    Lock.acquire t.lock;
-    let n = Queue.length t.queue in
-    let elem_opt = Queue.take_opt t.queue in
-    Lock.release t.lock;
-    if n = t.capacity then Lock.Condition.broadcast t.not_full;
-    elem_opt
+    if Sem.try_acquire t.length then begin
+      match Lock.acquire t.lock with
+      | () ->
+          let elem_opt = Queue.take_opt t.queue in
+          Lock.release t.lock;
+          Sem.release t.capacity;
+          elem_opt
+      | exception exn ->
+          let bt = Printexc.get_raw_backtrace () in
+          Sem.release t.length;
+          Printexc.raise_with_backtrace exn bt
+    end
+    else None
 end
 
 let run_one_domain ~budgetf ?(n_msgs = 25 * Util.iter_factor) () =