5.2 support: Raw identifiers (by changing the Parsetree) #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most strings in the extended Parsetree are replaced by the 'ident' type, which represents the original syntax used to write the identifier. The new representation can differentiate regular identifiers from parenthesed operators (`( >>= )`), raw identifiers (`\#foo`) and constructors (`[]`, `true`).
This is mostly a type-directed refactoring.
|
The changes to the parser can be avoided entirely: #2621 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry of #2619 by keeping the original syntax of identifiers in the parsetree.
Strings in the Parsetree are replaced by the new
identtype, which represent the different kinds of identifiers:\#raw,( >>= ),[],true.This removes the need to guess whether an identifier needs parentheses and greatly simplifies the support of raw identifiers. Changes in
Fmt_astwere mostly type-directed.