Skip to content

Alignment issue with Fira Mono #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vphantom opened this issue Mar 15, 2022 · 2 comments
Closed

Alignment issue with Fira Mono #850

vphantom opened this issue Mar 15, 2022 · 2 comments
Labels
css invalid This doesn't seem right

Comments

@vphantom
Copy link

Hello! This is related to #397. Here's what I see with Odoc's choice of Fira Mono for a {v…v} block:

odoc_fira_mono16

If I change that font to Fira Code (which I happen to have installed), the ASCII art becomes seamless as expected:

odoc_fira_code16

Is Fira Mono, the CSS' assumptions around using it, or my system to blame? Here's the source for reference:

Module    │ Get (opt) │ Get (exn) │ Test
──────────┼───────────┼───────────┼───────
Hashtbl   │ .%()      │ .%^()     │ .%?()
StringSet │           │           │ .$?[]
StringMap │ .$()      │ .$^()     │ .$?()
IntMap    │ .!()      │ .!^()     │ .!?()
Custom... │ .@()      │           │
@Julow
Copy link
Collaborator

Julow commented Mar 29, 2022

Fira Code and Fira Mono are very different fonts, the latter doesn't have ligatures. This is the expected result.

ASCII art in documentation is not ideal because it's hard to maintain and you can't use other markups in it (eg. references). It seems that you need a markup for drawing a table.

@dbuenzli dbuenzli added css invalid This doesn't seem right labels Jun 8, 2022
@dbuenzli
Copy link
Contributor

dbuenzli commented Jun 9, 2022

Fira Code and Fira Mono are very different fonts, the latter doesn't have ligatures.

Indeed. It seems Fira Code was used at some point but switched over to Fira Mono due to legibility concerns see #248

So I'm afraid @Julow is right here:

This is the expected result.

Regarding:

ASCII art in documentation is not ideal because it's hard to maintain and you can't use other markups in it (eg. references). It seems that you need a markup for drawing a table.

An issue was opened for this in #864.

@dbuenzli dbuenzli closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants