Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No newline at end of file in html files #952

Closed
3Rafal opened this issue Apr 5, 2023 · 2 comments · Fixed by #954
Closed

No newline at end of file in html files #952

3Rafal opened this issue Apr 5, 2023 · 2 comments · Fixed by #954

Comments

@3Rafal
Copy link
Contributor

3Rafal commented Apr 5, 2023

When generating test cases for #950 , I've found out that generated html files don't end with a new line.
This results in git warning: No newline at end of file and is shown as red marker on GitHub:
Screenshot 2023-04-05 at 10 22 05

The issue doesn't occur for other outputs (tex, man).

@Julow
Copy link
Collaborator

Julow commented Apr 7, 2023

The problem seems to be located here: https://github.com/ocaml/odoc/blob/master/src/html/html_page.ml#L149
Tyxml's pp function doesn't output a newline so we need to output one in the content function. The same bug occurs for source pages below.
Would you be interested in fixing this ?

@3Rafal
Copy link
Contributor Author

3Rafal commented Apr 7, 2023

Sure, I'll try to fix it. :) Thanks for heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants