Merge pull request #5995 from dra27/write-reg

Always pass `--no-write-registry` to Cygwin setup
ocaml · Jun 6, 2024 · e9bb7ba · e9bb7ba
2 parents 2a51251 + c00842e
commit e9bb7ba
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/master_changes.md b/master_changes.md
@@ -87,6 +87,7 @@ users)
   * Pass --symlink-type native to Cygwin setup if symlinks are available [#5830 @dra27]
   * Pass --no-version-check to Cygwin setup (suppresses a message box if setup needs updating) [#5830 @dra27]
   * Pass --quiet-mode noinput to stop the user interrupting the setup GUI [#5830 @dra27]
+  * Always pass --no-write-registry to the Cygwin installer, not just on first installation [#5995 @dra27]
 
 ## Format upgrade
   * Handle init OCaml `sys-ocaml-*` eval variables during format upgrade from 2.0 -> 2.1 -> 2.2 [#5829 @dra27]

diff --git a/src/state/opamSysInteract.ml b/src/state/opamSysInteract.ml
@@ -984,6 +984,7 @@ let install_packages_commands_t ?(env=OpamVariable.Map.empty) config sys_package
             let common =
               [ "--upgrade-also";
                 "--only-site";
+                "--no-write-registry";
                 "--no-version-check";
                 "--site"; Cygwin.mirror;
                 "--local-package-dir";