Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matching based on platform.features and platform.compatibilities #1

Open
wants to merge 1 commit into
base: wg-compat-proposal-a-e-h
Choose a base branch
from

Conversation

mfranczy
Copy link
Collaborator

@mfranczy mfranczy commented Jul 8, 2024

That is a simple prototype to show how we could improve image selection in containerd.
The code of this prototype should be improved and maybe platforms in a few places refactored, however, it solves the problem and shows the general idea which is:

  • use platform.features for CPU features
  • introduce platform.compatibilities which is a map that allows to provide matching labels.

Additionally, I introduced a new config file /etc/containerd/platform-config.toml where people can provide information to containerd services about nodes cpu features and compatibility data.

Example of the new config file:

features = ["avx512"]

[compatibilities]
  "oci.kernel.modules.kvm" = "true"

@mfranczy mfranczy force-pushed the image-selection-e-h branch from 79aa68f to caaa78f Compare July 8, 2024 13:53
@mfranczy mfranczy changed the base branch from main to wg-compat-proposal-a-e-h July 8, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant