Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerelease tag warnings not working as expected #47

Open
jk05 opened this issue Jun 29, 2020 · 3 comments
Open

Prerelease tag warnings not working as expected #47

jk05 opened this issue Jun 29, 2020 · 3 comments
Labels
enhancement New feature or request help wanted Accepting PRs

Comments

@jk05
Copy link

jk05 commented Jun 29, 2020

When working with prerelease tags, we've noticed that the the plugin will warn the first time when a prerelease version has been published, for example x.x.x to x.x.x-alpha.x.

However, after that when the version has been bumped to prerelease, due to https://github.com/oclif/plugin-warn-if-update-available/blob/master/src/hooks/init/check-update.ts#L27 , there seems to be an early return due to the existence of -and there appears to no longer be any warning shown for further updates whether a prerelease or not. https://github.com/oclif/plugin-warn-if-update-available/blob/master/src/hooks/init/check-update.ts#L31 seems to indicate the possibility of splitting on a - and comparing at least the first part.

We were wondering what the reasoning is for the early return or if this is a case of unfinished logic?

Thanks

@RasPhilCo
Copy link
Contributor

Sounds like a bug if a minor/patch doesn't warn again.

@RasPhilCo RasPhilCo added the bug label Jul 3, 2020
@mdonnalley mdonnalley added help wanted Accepting PRs and removed bug labels Mar 20, 2024
@This78
Copy link

This78 commented May 10, 2024

@mdonnalley mdonnalley added the enhancement New feature or request label Aug 1, 2024
Copy link

git2gus bot commented Aug 1, 2024

This issue has been linked to a new work item: W-16393788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Accepting PRs
Projects
None yet
Development

No branches or pull requests

4 participants