-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support changing the endpoint of Octo STS for Self hosting #26
Comments
✅ I'll send a pull request soon. |
I think it maybe not enough as i saw |
📝
https://github.com/search?q=repo%3Aocto-sts%2Fapp%20octo-sts.dev&type=code ~/repos/src/github.com/octo-sts/app main
$ git grep octo-sts.dev
README.md: "https://octo-sts.dev/sts/exchange?scope=${REPO}&identity=${NAME}"
iac/gclb.tf: name = "octo-sts-dev"
iac/gclb.tf: dns_name = "octo-sts.dev."
iac/gclb.tf: description = "DNS zone for domain: octo-sts.dev"
iac/gclb.tf: "octo-sts.dev" = {
pkg/octosts/octosts.go: event.SetSource("https://octo-sts.dev")
pkg/octosts/octosts.go: ClientID: "octo-sts.dev",
pkg/prober/prober.go: "https://octo-sts.dev",
pkg/prober/prober.go: ts, err := idtoken.NewTokenSource(ctx, "octo-sts.dev" /* aud */)
pkg/prober/prober.go: "https://octo-sts.dev",
pkg/prober/prober.go: "https://octo-sts.dev",
pkg/prober/prober.go: ts, err := idtoken.NewTokenSource(ctx, "octo-sts.dev" /* aud */) |
Looks like issue was already fixed by #28 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now the endpoint of Octo STS is hardcoded to
https://octo-sts.dev/sts/exchange
.action/index.js
Line 42 in 3622e4d
To use this action with self-hosted Octo STS, we need to change the endpoint.
So how about adding an optional input variable
endpoint
to change the endpoint?The default value is
https://octo-sts.dev/sts/exchange
.e.g.
The text was updated successfully, but these errors were encountered: